-
-
Notifications
You must be signed in to change notification settings - Fork 391
test that matplotlib event loop integration is responsive #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
all the matplotlib tests are passing on mac and windows, need to figure out why linux isn't enabling the event loops |
and increase timeout for tk
Perhaps you need to run that test with |
Probably right, looking at that. |
|
Changes look good to me, and tests pass locally on both macos and linux. I don't understand the CI failures but I assume they are related to |
|
with xvfb, the tests are hanging after |
seems to be hanging with xvfb available
ci can be super slow
can't seem to get it right, let's unblock and fix that later
|
Is it worth just disabling the reliably-failing |
|
Yes, I think so. Sorry I couldn't figure out how to get these more reliable. They pass 100% every time I test locally, so I think it's something about how slow ci environments are |
seems very flaky
they pass locally, so keep the tests, but don't keep holding up release with slow, flaky tests
|
I give up, I just skipped the tests altogether on CI. They are too flaky. I'm sure there's some race somewhere, perhaps in where the kernel runs the cell activating the event loop and then enters the eventloop mode, maybe a message can get dropped or stuck waiting somewhere? It could be a real bug, but I don't want to hold up the 7.1 release anymore, and this does have the But these tests pass 100% for me locally, so I at least know that they verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @minrk, I completely agree. Approving and merging this with CI disabled so that I can proceed with the 7.1.0 release and we can circle back to this later.
also fixes
%matplotlib osxwhich gets converted tomacosxon its way through matplotlib and backThis should hopefully be the regression test for #1458