Use ProgressTrack in progress renderer #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
approved these changes
May 20, 2024
src/mechanics/mechanics-blocks.ts
Outdated
| node.properties.from ?? | ||
| ((node.properties["from-boxes"] as number) ?? 0) * 4 + | ||
| ((node.properties["from-ticks"] as number) ?? 0), | ||
| difficulty: node.properties.level, |
There was a problem hiding this comment.
Is was meaning to change this: the correct name for this, I believe, is "rank", so maybe we can make that change right here, too. We'll want to fall back to "level" for backwards compat, though.
There was a problem hiding this comment.
Ah, yeah, you are right. I think Difficulty came from the original Forged in Obsidian track format, and I kept it for backwards compatibility, but I, too, had intended to change the name. I'll make that change in this PR in both spots.
Maintains backwards compatability with old `level` and `difficulty` terms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the
progressnode renderer to use theProgressTrackclass for progress calculations.This fixes cases where steps could take tracks past 10 boxes.
Also adds support for unbounded tracks (like the legacy tracks) with an optional
unboundedboolean property.