chore: support build as a flutter module #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When build as a flutter module and integrated into the existing android project, there is no applicationVariants and result in following compilation failure: Could not get unknown property 'applicationVariants' for extension 'android' of type com.android.build.gradle.LibraryExtension. In such case, we will use libraryVariants instead
|
Not an expert on github action CI. From the error message It seems the github action CI is using Java 21 (class version 65) and gradle 7.5 doesn't support it The command to execute the gradle task is Not sure why it is using JDK 21 as the workfile specifies the JDK11? |
added 3 commits
May 30, 2024 11:18
Sometimes gradle may use JDK21 to execute the task which is not supported by gradle7.5 Ensure Gradle uses the correct Java home during the Android build step
If MacOS is running on the Apple M chips, we should pick the correct arch
Change the JAVA SDK to JAVA17 on MacOS arm64 chips This commit is to fix the following error when running action on MacOS target with Apple sillicon chips. Error: LinkageError occurred while loading main class com.android.sdklib.tool.sdkmanager.SdkManagerCli java.lang.UnsupportedClassVersionError: com/android/sdklib/tool/sdkmanager/SdkManagerCli has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0 The class com.android.sdklib.tool.sdkmanager.SdkManagerCli was compiled with a newer version of Java (class file version 61.0, which corresponds to Java 17), but the Java runtime environment being used only supports class file versions up to 55.0 (which corresponds to Java 11).
|
@knopp Could you take a look of this PR? I also managed to fix the workflow failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build as a flutter module and integrated into the existing android project, there is no applicationVariants and result in following compilation failure:
Could not get unknown property 'applicationVariants' for extension 'android' of type com.android.build.gradle.LibraryExtension.
In such case, we will use libraryVariants instead
superlistapp/super_native_extensions#379