Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added holes.pl, lists all open sockets, only meaningful if running in… #870

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

terminaldweller
Copy link
Contributor

holes.pl lists all the open sockets you have. This obviously only makes sense if you are running inside an application container where irssi is the only one making sockets.

scripts/holes.pl Outdated
my $holes = "";
my $timeout;
my $holes_cmd = << 'HOLES_CMD';
lsof | grep socket | awk '{print $4}' | awk 'BEGIN{FS=":"}{print $2}' | tr -d [] | uniq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[] should be quoted as it can be a metachar depending on your shell

(maybe the pipe could be implemented in perl instead)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. ill go learn what the thing you just said means.

sub holes_sub {
my $result;
Irssi::timeout_remove($timeout);
my $output = `$holes_cmd`;
Copy link
Contributor

@ailin-nemui ailin-nemui Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be mindful, synchronous execution of command can stall irssi especially if you have a lot of open files

(maybe ss or netstat is faster)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont expect this to take long since running this script only makes sense if you are running it inside an applicatino container. The comments explicitly mention that.
But generally, you're right.

@ailin-nemui ailin-nemui merged commit 2e9f650 into irssi:master Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants