Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create oliver domain #19654

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Create oliver domain #19654

wants to merge 5 commits into from

Conversation

Oli-Ward
Copy link

@Oli-Ward Oli-Ward commented Feb 6, 2025

Requirements

Unless explicitly specified otherwise by a maintainer or in the requirement description, your domain MUST pass ALL the indicated requirements below.

  • [ X ] I have read and understood the Terms of Service.
  • [ X ] My domain is not for commercial use.
  • [ X ] My file is in the domains directory and has the .json file extension.
  • [ X ] My file's name is lowercased and alphanumeric.
  • [ X ] My website is reachable.
  • [ X ] I have completed my website.
  • [ X ] My website is related to software development.
  • [ X ] I have provided sufficient contact information in the owner key.
  • [ X ] I have followed and read the documentation.
  • [ X ] I understand my domain will be removed if I violate the Terms of Service.

Website Preview

https://is-a-dev-zc9.pages.dev/

@Oli-Ward Oli-Ward requested a review from a team as a code owner February 6, 2025 15:55
JustDeveloper1
JustDeveloper1 reviewed Feb 9, 2025
View reviewed changes
Copy link
Contributor

@JustDeveloper1 JustDeveloper1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file must be .json

JustDeveloper1
JustDeveloper1 reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@JustDeveloper1 JustDeveloper1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you need to complete your website and remove https:// and / in CNAME record.
i dont understand why you requested my review, i am not a maintainer (i cant merge or close or request changes on your pull ruquest).

domains/oliver.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete website
image

domains/oliver.json Outdated
"email": "[email protected]"
},
"record": {
"CNAME": "https://is-a-dev-zc9.pages.dev/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove https:// and /.

"CNAME": "is-a-dev-zc9.pages.dev"

CNAME record must contain only domain, not url.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustDeveloper1 also apologies I did not realise you were not a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustDeveloper1 JustDeveloper1 JustDeveloper1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
domain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oli-Ward @JustDeveloper1