Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

register #20557

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

register #20557

wants to merge 6 commits into from
+19 −0

Conversation

777Vincent
Copy link

Requirements

  • I have read and understood the Terms of Service.
  • I understand my domain will be removed if I violate the Terms of Service.
  • My file is in the domains directory and has the .json file extension.
  • My file's name is lowercased and alphanumeric.
  • My website is reachable and completed.
  • I have provided sufficient contact information in the owner key.

Website Preview

image

@777Vincent 777Vincent requested a review from a team as a code owner February 25, 2025 06:10
JustDeveloper1
JustDeveloper1 reviewed Feb 25, 2025
View reviewed changes
iostpa
iostpa requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@iostpa iostpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is invalid because of the email and records.

Please either add an email, add a social media handle or just leave the username section there.

For the records, please either proxy the domain (by changing the proxied string) or change from CNAME to URL (first option is better though).

@iostpa iostpa added the reason: invalid file Your file is invalid or improper. label Feb 26, 2025
@777Vincent 777Vincent requested a review from iostpa February 27, 2025 00:40
@777Vincent
Copy link
Author

i believe this should be good, networking stuff confuses me sorry :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustDeveloper1 JustDeveloper1 JustDeveloper1 left review comments

@iostpa iostpa Awaiting requested review from iostpa

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
domain reason: invalid file Your file is invalid or improper.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@777Vincent @iostpa @JustDeveloper1