Skip to content

Conversation

hapatel-bdai
Copy link
Collaborator

@hapatel-bdai hapatel-bdai commented Apr 4, 2025

Description

Adding new collision mesh property options allowing users to configure meshes to add different collision types

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Copy link
Collaborator

@jsmith-bdai jsmith-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kellyguo11 kellyguo11 changed the title Collision Mesh Schema Additions Adds new Collision Mesh Schema properties May 11, 2025
@kellyguo11
Copy link
Contributor

A bunch of tests seem to be failing on this one, @jsmith-bdai would you mind taking a look?

@jtigue-bdai jtigue-bdai self-requested a review as a code owner August 12, 2025 14:08
Copy link

github-actions bot commented Aug 12, 2025

Test Results Summary

2 446 tests   2 038 ✅  2h 14m 30s ⏱️
   92 suites    408 💤
    1 files        0 ❌

Results for commit 28daa58.

♻️ This comment has been updated with latest results.

@jtigue-bdai jtigue-bdai force-pushed the hapatel/collision_mesh_schema branch from f302994 to fcd8b98 Compare August 12, 2025 18:20
@kellyguo11 kellyguo11 closed this Aug 27, 2025
@kellyguo11 kellyguo11 deleted the hapatel/collision_mesh_schema branch August 27, 2025 00:24
@jtigue-bdai jtigue-bdai restored the hapatel/collision_mesh_schema branch August 27, 2025 14:01
@jtigue-bdai
Copy link
Collaborator

@kellyguo11 reopening

@jtigue-bdai jtigue-bdai reopened this Aug 27, 2025
@kellyguo11
Copy link
Contributor

ah sorry, I think it got closed when I renamed the branch...let's just keep this branch then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants