-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Adds new Collision Mesh Schema properties #2249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A bunch of tests seem to be failing on this one, @jsmith-bdai would you mind taking a look? |
Test Results Summary2 446 tests 2 038 ✅ 2h 14m 30s ⏱️ Results for commit 28daa58. ♻️ This comment has been updated with latest results. |
Added to contributors list Signed-off-by: Harsh Patel <[email protected]>
Signed-off-by: Harsh Patel <[email protected]>
Signed-off-by: Harsh Patel <[email protected]>
f302994
to
fcd8b98
Compare
@kellyguo11 reopening |
ah sorry, I think it got closed when I renamed the branch...let's just keep this branch then |
Description
Adding new collision mesh property options allowing users to configure meshes to add different collision types
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there