-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fixes DCMotor clipping for negative power and adds actuator tests #2300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jtigue-bdai
wants to merge
22
commits into
isaac-sim:main
Choose a base branch
from
jtigue-bdai:jat/feat/q4_dc_motor_limits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes DCMotor clipping for negative power and adds actuator tests #2300
jtigue-bdai
wants to merge
22
commits into
isaac-sim:main
from
jtigue-bdai:jat/feat/q4_dc_motor_limits
+778
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
hmm looks like the DC motor and environment tests are both failing, along with a few others, but not sure if they are all related to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for actuator initialization, configuration, and computation for Implicit, IdealPD, and DC motor actuators.
This PR also updates the DCMotor model to clip based on a four quadrant DC motor model. This will fix improper clipping in the negative power regions (i.e. positive torque and negative velocity or negative torque and positive velocity).
NOTE: This PR is dependant on the pytest migration in: 2034
This PR includes changes made in 2291 and would be an alternate candidate.
Fixes #2139
Type of change
Screenshots
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there