Add debug_viz_z height for UniformVelocityCommand #2312
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: nburger <[email protected]>
burgern
requested review from
jsmith-bdai,
kellyguo11 and
Mayankm96
as code owners
burgern
changed the title
Mayankm96
reviewed
May 7, 2025
| @@ -81,6 +81,9 @@ class Ranges: | |||
| ranges: Ranges = MISSING | |||
| """Distribution ranges for the velocity commands.""" | |||
|
|
|||
| debug_vis_z: float = 0.5 | |||
| """Height at which the visualizer gets set (w.r.t. root_pos_w).""" | |||
There was a problem hiding this comment.
It's recommended to always state the default values in docstrings.
Suggested change
| """Height at which the visualizer gets set (w.r.t. root_pos_w).""" | |
| """Height at which the visualizer gets set (w.r.t. root_pos_w). Defaults to 0.5 m.""" |
There was a problem hiding this comment.
Could you also change some of the humanoid examples to make sure this flag is getting used properly? (Also to fix it over there)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to improve the visualization of velocity commands. Specifically, it adjusts the vertical offset of the command display for certain robots, raising it above the default height of 0.5 to avoid overlapping with humanoid heads.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there