Fixes the issue of using Modifiers and history buffer together #2461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The modifier should get `obs_dims` before modified by history_buffer initialization, since Modifiers are called before the history buffer.
ZiwenZhuang
force-pushed
the
fix/observation-modifier-history
branch
from
542b81a to
a4f2e1c
Compare
jtigue-bdai
approved these changes
May 15, 2025
Collaborator
jtigue-bdai
left a comment
jtigue-bdai
left a comment
There was a problem hiding this comment.
Thank you for the catch and for trying both modifiers and history.
yrh012
pushed a commit
to aica-technology/isaac-lab
that referenced
this pull request
Jun 16, 2025
…-sim#2461) # Description The modifier should get `obs_dims` before modified by history_buffer initialization, since Modifiers are called before the history buffer. Fixes isaac-sim#2460 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots <img width="1594" alt="screenshots2025-05-10 14 19 57" src="https://github.com/user-attachments/assets/6d1d65e4-3ac4-4842-8a14-5cafb5521045" /> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there Co-authored-by: James Tigue <[email protected]>
harry-wf-cheung
pushed a commit
to harry-wf-cheung/IsaacLab-Harry
that referenced
this pull request
Jul 30, 2025
…-sim#2461) # Description The modifier should get `obs_dims` before modified by history_buffer initialization, since Modifiers are called before the history buffer. Fixes isaac-sim#2460 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots <img width="1594" alt="screenshots2025-05-10 14 19 57" src="https://github.com/user-attachments/assets/6d1d65e4-3ac4-4842-8a14-5cafb5521045" /> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there Co-authored-by: James Tigue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The modifier should get
obs_dimsbefore modified by history_buffer initialization, since Modifiers are called before the history buffer.Fixes #2460
Type of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there