Skip to content

Comments

Migrate "marksAwarded" field to "marks" in question_attempts JSON#755

Merged
jsharkey13 merged 4 commits intomainfrom
improvement/remove-marksAwarded
Feb 16, 2026
Merged

Migrate "marksAwarded" field to "marks" in question_attempts JSON#755
jsharkey13 merged 4 commits intomainfrom
improvement/remove-marksAwarded

Conversation

@sjd210
Copy link
Contributor

@sjd210 sjd210 commented Feb 4, 2026

Also requires isaacphysics/isaac-react-app#1960

The database migration will only need to be applied to Ada on live (although both sites on staging) since LLM-marked questions were never enabled for Sci. It should be safe to do right away/on release since the old API will still be writing to both marksAwarded and marks. It may mean that some stragglers still also contain marksAwarded in their JSON, but this should be safe (just slightly redundant).

The term "marksAwarded" is still used for markedExamples but  this is under a different context and is okay to remain
Replaces "marksAwarded" field in JSON with "marks" field for consistent naming
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.91%. Comparing base (044f0a5) to head (c30fec7).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   39.92%   39.91%   -0.01%     
==========================================
  Files         545      545              
  Lines       23892    23887       -5     
  Branches     2873     2873              
==========================================
- Hits         9539     9535       -4     
+ Misses      13443    13442       -1     
  Partials      910      910              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sjd210 and others added 2 commits February 10, 2026 14:43
Co-authored-by: James Sharkey <jsharkey13@users.noreply.github.com>
@jsharkey13 jsharkey13 merged commit 6530d82 into main Feb 16, 2026
5 checks passed
@jsharkey13 jsharkey13 deleted the improvement/remove-marksAwarded branch February 16, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants