Migrate "marksAwarded" field to "marks" in question_attempts JSON#755
Merged
jsharkey13 merged 4 commits intomainfrom Feb 16, 2026
Merged
Migrate "marksAwarded" field to "marks" in question_attempts JSON#755jsharkey13 merged 4 commits intomainfrom
jsharkey13 merged 4 commits intomainfrom
Conversation
The term "marksAwarded" is still used for markedExamples but this is under a different context and is okay to remain
Replaces "marksAwarded" field in JSON with "marks" field for consistent naming
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 39.92% 39.91% -0.01%
==========================================
Files 545 545
Lines 23892 23887 -5
Branches 2873 2873
==========================================
- Hits 9539 9535 -4
+ Misses 13443 13442 -1
Partials 910 910 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsharkey13
reviewed
Feb 10, 2026
src/main/resources/db_scripts/migrations/2026-02-remove-marksawarded-validation-field.sql
Outdated
Show resolved
Hide resolved
src/main/resources/db_scripts/migrations/2026-02-remove-marksawarded-validation-field.sql
Show resolved
Hide resolved
Co-authored-by: James Sharkey <jsharkey13@users.noreply.github.com>
jsharkey13
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also requires isaacphysics/isaac-react-app#1960
The database migration will only need to be applied to Ada on live (although both sites on staging) since LLM-marked questions were never enabled for Sci. It should be safe to do right away/on release since the old API will still be writing to both
marksAwardedandmarks. It may mean that some stragglers still also containmarksAwardedin their JSON, but this should be safe (just slightly redundant).