Fix ElasticSearch ping InfoFacade endpoint#758
Merged
Conversation
This endpoint was not working because the cluster needs an authenticated request. It has been broken for a long time, but upgrading ES is a good reason to fix it. Fix the tests to actually verify the expected behaviour, too; we always return a 200 OK, so they did not notice that the endpoint was broken.
jsharkey13
commented
Feb 19, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 39.95% 39.95%
=======================================
Files 546 546
Lines 23886 23895 +9
Branches 2873 2873
=======================================
+ Hits 9543 9547 +4
- Misses 13435 13441 +6
+ Partials 908 907 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: James Sharkey <jsharkey13@users.noreply.github.com>
axlewin
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This endpoint was not working because the cluster needs an authenticated request. It has been broken for a long time, but upgrading ES is a good reason to fix it.
Fix the tests to actually verify the expected behaviour, too; we always return a 200 OK, so they did not notice that the endpoint was broken.