Adjust layout slightly for small (/non-fullWidth) ALVIs#2006
Open
Adjust layout slightly for small (/non-fullWidth) ALVIs#2006
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
+ Coverage 43.19% 43.22% +0.02%
==========================================
Files 575 575
Lines 24747 24747
Branches 8216 7343 -873
==========================================
+ Hits 10689 10696 +7
- Misses 13382 14002 +620
+ Partials 676 49 -627 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At explicitly small ALVI widths (when page is <=xs, or
fullWidthset to exactlyfalse), wrap title tags such as "DEPRECATED" and "NO-FILTER" to below the title so they take up less horizontal space.Also change
fullWidthrequirements on "My progress" from <=lg to {sm, lg, xl} to allow md pages to use a non-stacked layout (at full page-width), while also enabling it for xl pages to account for the new question status space requirements (at half page-width).Also requires isaacphysics/isaac-api#760