Fix 64-bit Hyprland window addresses - #38
Open
jacobaross wants to merge 1 commit into
Open
Conversation
Owner
|
Very nice change 👍🏻 One nit before merge though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u32::MAXProblem
Hyprland reports client addresses as pointer-sized hexadecimal strings, for example
0x56257ff1ebe0. The current backend parses those values withu32::from_str_radix(...).unwrap_or(0). On typical 64-bit Hyprland sessions the parse overflows, stores window ID0, and later dispatches focus/stack commands againstaddress:0x0instead of the EVE client.Tests
Local on macOS:
cargo test --bin Nicotine— 129 passedcargo test --bin Nicotine hyprland_address— 2 passedcargo fmt --checkcargo clippy --bin Nicotine -- -A dead-code -D warningsgit diff --checkNot run locally:
cargo test— currently reaches the pre-existing Linux-onlynix::sys::prctlcode intests/common/unix.rson macOSThe PR CI matrix should provide Linux unit/integration coverage plus Windows compile, unit, and fake-EVE integration coverage.