Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Implement Release channels #3135

Merged
merged 2 commits into from
Apr 22, 2024
Merged

[API] Implement Release channels #3135

merged 2 commits into from
Apr 22, 2024

Conversation

whitneygriffith
Copy link
Contributor

@whitneygriffith whitneygriffith commented Mar 20, 2024 •
edited
Loading

Part of #173

This PR:

  • adds the release channel: standard annotations to the EnvoyProxy and WasmPlugin resources that aren't stable and therefore would not be available in the stable Release channel.
  • generates the CRD yaml file per release channel based on #2797 and requires #2797 to merge first.

See RFC

@whitneygriffith whitneygriffith requested a review from a team as a code owner March 20, 2024 20:31
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2024
@whitneygriffith whitneygriffith added the do-not-merge Block automatic merging of a PR. label Mar 20, 2024
@whitneygriffith whitneygriffith self-assigned this Mar 25, 2024
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 4, 2024
MorrisLaw
MorrisLaw approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@MorrisLaw MorrisLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs a rebase though

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 8, 2024
@keithmattix
Copy link
Contributor

Need to rebase and update this to remove mentions of different CRD bundles

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 12, 2024
@whitneygriffith
implement release channels
6f8edd2 
Signed-off-by: whitneygriffith <[email protected]>
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2024
@whitneygriffith whitneygriffith force-pushed the release-channels branch 2 times, most recently from 6ad4373 to ea67b6c Compare April 13, 2024 20:36
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2024
@whitneygriffith
Copy link
Contributor Author

Need to rebase and update this to remove mentions of different CRD bundles

Done!

@whitneygriffith
Copy link
Contributor Author

PTAL @howardjohn @ericvn @therealmitchconnors

The releaseChannel annotation is still valid for automating the VAPs in future iterations.

@whitneygriffith whitneygriffith removed the do-not-merge Block automatic merging of a PR. label Apr 22, 2024
@istio-testing istio-testing merged commit ebd4d88 into istio:master Apr 22, 2024
5 checks passed
@whitneygriffith whitneygriffith deleted the release-channels branch April 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@keithmattix keithmattix keithmattix approved these changes

@MorrisLaw MorrisLaw MorrisLaw approved these changes

@ericvn ericvn ericvn approved these changes

@jaellio jaellio jaellio approved these changes

Assignees

@whitneygriffith whitneygriffith

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@whitneygriffith @keithmattix @howardjohn @MorrisLaw @ericvn @jaellio @istio-testing