Skip to content

Conversation

@libesz
Copy link

@libesz libesz commented May 26, 2025

Ignore env vars with multiline values. They are failing make targets if present.

@libesz libesz requested a review from a team as a code owner May 26, 2025 11:09
@istio-policy-bot
Copy link

😊 Welcome @libesz! This is either your first contribution to the Istio common-files repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing
Copy link
Contributor

Hi @libesz. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 26, 2025
@libesz
Copy link
Author

libesz commented Jul 25, 2025

We've hit this issue now also in CI builds, not only locally. E.g. Travis sets up env vars like the actual commit message, which may be multiline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants