Skip to content

fix site menu #16524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

fix site menu #16524

merged 1 commit into from
May 29, 2025

Conversation

Ajay-singh1
Copy link
Contributor

Description

This PR resolves issue:- #16520

Attached Screenshot for reference:-
Istio

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@Ajay-singh1 Ajay-singh1 requested a review from a team as a code owner May 27, 2025 11:05
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels May 27, 2025
@istio-testing
Copy link
Contributor

Hi @Ajay-singh1. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Arhell
Arhell reviewed May 28, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 28, 2025
craigbox
craigbox requested changes May 28, 2025
View reviewed changes
layouts/partials/navigation_level.html Outdated
Comment on lines 64 to 66
<button {{ if not $collapse }} class="show" {{ end }} aria-hidden="true" tabindex="-1"></button>
<a title="{{ $desc }}" href="{{ .Permalink }}">{{ $linktitle }}</a>
{{ partial "navigation_level.html" (dict "pages" .Pages "parent" . "current" $current "collapse" $collapse "top" false "labelledby" "" "depth" (add $depth 1)) }}
Copy link
Contributor

@craigbox craigbox May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even need the depth to make this work, and tbh I would have thought {{ if lt (len $pageLocation) 6 }} would catch that. But ChatGPT did give me the same suggestion 😄

I spent some time digging into this last night.

The issue is the use of partialCached, which I believe was added to get decent build performance. That has been removed in both versions, and re-adding it to this PR still causes the problem to recur.

If I revert the file to e24e58a and change partialCached to partial on L66 I get a working fix. I think we should do that for now please.

I have asked the question of the Hugo maintainers.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2025
@Ajay-singh1
Copy link
Contributor Author

Ohh Wow! Genius 🤯.Changing partialCached to partial did the job.Thanks @craigbox

@istio-testing istio-testing merged commit fe3c859 into istio:master May 29, 2025
6 checks passed
@craigbox
Copy link
Contributor

hooray https://preliminary.istio.io/latest/docs/ is back at little cost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@craigbox craigbox craigbox approved these changes

Assignees
No one assigned
Labels
kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ajay-singh1 @istio-testing @craigbox @Arhell @istio-policy-bot