[release-1.25] bump Go #3183
Merged
[release-1.25] bump Go #3183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Hawton <[email protected]>
istio-testing
added
the
size/XS
Signed-off-by: Daniel Hawton <[email protected]>
mikemorris
reviewed
Apr 9, 2025
| RUN curl --proto '=https' -v --tlsv1.2 -sSf https://sh.rustup.rs | \ | ||
| sh -s -- -y -v --default-toolchain ${RUST_VERSION} --profile minimal \ | ||
| --component rustfmt clippy --component llvm-tools &&\ | ||
| --component rustfmt --component clippy --component llvm-tools &&\ |
There was a problem hiding this comment.
Is this the fix we want (to mirror the change on master in #3157) and if so is it worth updating release-1.24 which was fixed differently in 7d1c19c for consistency?
Refs context in #3160 (comment)
There was a problem hiding this comment.
I don't think we need to touch release 1.24. this fails without so I mirrored master.
mikemorris
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.