add registry polyfill info to getting started #345
Conversation
chrisjbrown
requested review from
SMQuazi,
jialin-he and
satya-achanta-venkata
and removed request for
a team
|
size-limit report 📦
|
| This is generally achieved by including this script tag in the head of your application. | ||
|
|
||
| ```javascript | ||
| <script src="https://cdn.jsdelivr.net/npm/@webcomponents/[email protected]/scoped-custom-element-registry.min.js"></script> |
There was a problem hiding this comment.
The latest version is 0.0.5. Not sure if that should be the recommendation (perhaps should be tested first).
There was a problem hiding this comment.
what would be a satisfactory way to test this?
There was a problem hiding this comment.
Use that version on a page that has at least a couple mfes registering components and ensure there aren't any console/JS errors I'd say.
There was a problem hiding this comment.
updating to version >= 0.0.4 ends up breaking some unit tests
specifically
Co-authored-by: Dane Hillard <[email protected]>
This reverts commit db52184.
* add registry polyfill info to getting started * Update packages/pharos-site/src/pages/getting-started.mdx Co-authored-by: Dane Hillard <[email protected]> * chore(deps): add registry polyfill info to getting started * Revert "chore(deps): add registry polyfill info to getting started" This reverts commit db52184. * chore(docs): fix linting using jsx Co-authored-by: Dane Hillard <[email protected]>
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
A clear and concise description or a direct link to an issue [e.g. #15]
If adding a feature, a rationale for its addition goes here.
How does this change work?
A clear, detailed description of how this change addresses the issue.
This could be a bullet list if there are several moving parts.
Additional context
Add any other context here.