Skip to content

Conversation

turegjorup
Copy link
Contributor

Add build release jobs to standard github actions

@turegjorup turegjorup requested a review from rimi-itk July 29, 2025 08:53
@turegjorup turegjorup self-assigned this Jul 29, 2025
Copy link
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Some comments added.

- name: Composer install
run: |
docker network create frontend
docker compose run --rm --user=root phpfpm composer install --no-dev -o --classmap-authoritative
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When env.COMPOSE_USER is set to runner, we don't need --user=… here:

Suggested change
docker compose run --rm --user=root phpfpm composer install --no-dev -o --classmap-authoritative
docker compose run --rm phpfpm composer install --no-dev -o --classmap-authoritative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants