Skip to content

Changed COMPOSE_USER to runner #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tuj merged 2 commits into from
Nov 17, 2025
Merged

Changed COMPOSE_USER to runner #121

tuj merged 2 commits into from
Nov 17, 2025

Conversation

@tuj
Copy link
Contributor

@tuj tuj commented Nov 17, 2025

No description provided.

@tuj tuj requested a review from turegjorup November 17, 2025 12:58
@tuj tuj self-assigned this Nov 17, 2025
@tuj tuj added the bug Something isn't working label Nov 17, 2025
turegjorup
turegjorup approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@turegjorup turegjorup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - but please fix markdown linting errors for CHANGELOG.md

@tuj tuj merged commit 953d1b0 into develop Nov 17, 2025
18 checks passed
@tuj tuj deleted the feature/compose-user-runner branch November 17, 2025 13:15
@rimi-itk
Copy link
Contributor

rimi-itk commented Nov 17, 2025

@tuj @turegjorup are we sure that this also works for images that don't have a runner user (I'm not sure if the Prettier and Markdownlint images we use do)?

@turegjorup
Copy link
Contributor

turegjorup commented Nov 17, 2025

@tuj @turegjorup are we sure that this also works for images that don't have a runner user (I'm not sure if the Prettier and Markdownlint images we use do)?

Good catch. And no we´re not. I don't know if Prettier Markdown has a runner user or if it's tested.

@tuj
Copy link
Contributor Author

tuj commented Nov 18, 2025

@tuj @turegjorup are we sure that this also works for images that don't have a runner user (I'm not sure if the Prettier and Markdownlint images we use do)?

Good catch. And no we´re not. I don't know if Prettier Markdown has a runner user or if it's tested.

We do not specify COMPOSE_USER for prettier and markdown actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turegjorup turegjorup turegjorup approved these changes

Assignees

@tuj tuj

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tuj @rimi-itk @turegjorup