feat(runtime): add provider capabilities and executor routing - #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design
The generic apply package now owns only provider contracts, route lookup, runtime state, preview gating, and execution lifecycle behavior. Instagram and Reddit each supply an explicit
simulationprovider backed by the existing no-op executor. Missing providers, unsupported actions, or unregistered modes block preview; there is no implicit no-op fallback.Instagram retains local export import and assisted manual cleanup. Reddit retains its read-only official API planner prototype, with developer access still pending. Its connection prerequisite is provider-owned and reads generic runtime state.
Review follow-up
Platform.ActionAvailablegate used by platform details; keyboard and mouse now share the disabled-action pathLabel: supportcapability rows only on platform detailSkipActionchanges asPlanActionEdit, while routed skipped execution events retain mode/executor identity through audit fieldsProvider.Executorexactly once per run, reuse that instance for every action, and fail closed when it is unavailableCompatibility
Deferred to PR 13 and later
Validation
gofmtcleango test -count=1 ./...go vet ./...go build ./cmd/vanishscripts/check-safety.sh(executed through a CRLF-clean stdin wrapper on Windows)git diff --check origin/main...HEADProvider.Executorcall site, no blank routed skip identity, no plan JSON changes, and no follow-up docs/release changesNo tags or GitHub Releases were created or modified.