Migrate linting to Oxlint - #30
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
website-v1 | 8890fbc | Jan 03 2026, 10:18 AM |
There was a problem hiding this comment.
Performed full review of c4c7120...a307a7c
Analysis
-
Incomplete CLI Invocation - The lint scripts use just
oxlintwithout specifying target paths (should beoxlint .), potentially resulting in incomplete linting coverage. -
Tooling Maturity Risk - Oxlint v1.2.0 is relatively new compared to the mature ESLint ecosystem, which may lead to edge cases or missing features that only become apparent post-migration.
-
Missing Binary Issue - The PR description indicates
pnpm lintfailed because the oxlint binary wasn't present in the environment, suggesting the lockfile needs to be updated before merging. -
Schema Validation Concerns - The schema path in
.oxlintrc.jsonmay be inaccurate, potentially reducing IDE support quality for developers.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
0 files reviewed | 3 comments | Edit Agent Settings • Read Docs
| "start": "next start", | ||
| "lint": "eslint .", | ||
| "lint": "oxlint", | ||
| "lint:fix": "oxlint --fix", |
There was a problem hiding this comment.
Similar to the lint script, the lint:fix script should explicitly specify a target path (e.g., oxlint --fix .) to ensure all project files are linted and fixed.
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: ivanleomk/website-v4#30
File: package.json#L11
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
Similar to the `lint` script, the `lint:fix` script should explicitly specify a target path (e.g., `oxlint --fix .`) to ensure all project files are linted and fixed.
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "$schema": "./node_modules/oxlint/configuration_schema.json", | |||
There was a problem hiding this comment.
The schema path ./node_modules/oxlint/configuration_schema.json may not exist at this location. Oxlint typically provides the schema at a different path or via a URL. Verify this path is correct, or consider using the official schema URL to enable proper IDE validation and autocomplete.
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: ivanleomk/website-v4#30
File: .oxlintrc.json#L2
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
The schema path `./node_modules/oxlint/configuration_schema.json` may not exist at this location. Oxlint typically provides the schema at a different path or via a URL. Verify this path is correct, or consider using the official schema URL to enable proper IDE validation and autocomplete.
| "build": "node scripts/generate-static-data.js && next build", | ||
| "start": "next start", | ||
| "lint": "eslint .", | ||
| "lint": "oxlint", |
There was a problem hiding this comment.
The lint script changed from eslint . to just oxlint without specifying a target path. According to Oxlint's CLI behavior, you should explicitly specify the path to lint (e.g., oxlint . or oxlint src/). Without a path argument, Oxlint may not lint all files in the project as expected.
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: ivanleomk/website-v4#30
File: package.json#L10
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
The lint script changed from `eslint .` to just `oxlint` without specifying a target path. According to Oxlint's CLI behavior, you should explicitly specify the path to lint (e.g., `oxlint .` or `oxlint src/`). Without a path argument, Oxlint may not lint all files in the project as expected.
Motivation
lint:fixhelper for applying automatic fixes.Description
lintscript tooxlintand addlint:fixwithoxlint --fixinpackage.json.eslint/eslint-config-nextdev-dependencies withoxlintinpackage.json..oxlintrc.jsonwith plugins (eslint,typescript,unicorn,oxc,react,jsx-a11y,nextjs,import) andignorePatternsfornode_modules,.next,out,build, andnext-env.d.ts.eslint.config.mjsflat config file.Testing
pnpm build, which completed successfully and produced a working Next.js production build.timeout 5 pnpm dev, which started Next.js but the local dev command was terminated by the timeout.pnpm lint, which failed because theoxlintbinary was not present in the environment (needs to be installed as a dev dependency in the lockfile).pnpm tc, which failed because thetcscript is not defined inpackage.json(usepnpm tscfor type checks).Codex Task
TL;DR
Replaced the ESLint configuration with Oxlint for improved linting performance and a simpler setup.
Why we made these changes
lint:fixcommand for automatically applying fixes.What changed?
eslintandeslint-config-nextdev dependencies withoxlintinpackage.json.lintscript to useoxlintand added alint:fixscript inpackage.json..oxlintrc.jsonconfiguration file with standard ignore patterns and plugins forreact,nextjs,typescript, andimport.eslint.config.mjsfile.Validation
pnpm buildwhich completed successfully.pnpm devto ensure the development server starts correctly.pnpm lint.Description generated by Mesa. Update settings