Stop using removed std.Target functions in build.zig #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusg
changed the title
It works with zig 0.12.0, right? |
|
It should, yes. That's ancient though, I wouldn't recommend using anything older than 0.13 - 0.14 is on the horizon. |
|
Looks good. I have processed it. But has not pushed to github yet. |
ivmai
pushed a commit
that referenced
this pull request
Feb 22, 2025
PR #706 (bdwgc). * build.zig (build): Replace `t.isWasm()` to `t.cpu.arch.isWasm()`; replace `t.isDarwin()` to `t.os.tag.isDarwin()`.
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: ziglang/zig@481b7bf
This change is backwards compatible because the old functions are equivalent to the new code.