Add containerd tests #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Lilljedahl <[email protected]>
Signed-off-by: Matias Pan <[email protected]>
|
@iximiuz tests have failed because docker registry pull limits. If you can get a token that should make it pass or the alternative could be to just use a different registry like ghcr. 👐 cheers! |
|
Wow, that's impressive! TIL https://hub.docker.com/r/tianon/containerd. Thank you very much for your help Daggerizing cdebug, @marcosnils and @matipan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #48 which adds containerd tests to cdebug. There's one particular difference in this approach which is that we don't run
containerdas adaggerservice, but instead we just start it in background within aWithExecand then we just run thego testsnormally.