Merged
Conversation
The existing autojoin handler was a fire-and-forget joinRoom call with no error handling. When joinRoom failed (rate limit, network blip, timeout), the invite was permanently lost because the main sync token had already advanced. This caused the state bot to silently miss invites during bulk processing from the onboarding server. - Add joinRoomWithRetry with exponential backoff (500ms, 1s, 2s, 3 retries) - Add periodic invite sweep using a separate sync token and minimal filter to discover and join any missed invites (60s interval, 90s initial delay) - Only advance sweep sync token after all pending invites are joined, so failed joins are retried on the next sweep cycle - Prevent listener and timer leaks on duplicate setupOnClient calls - Add stopSweep method for clean shutdown - Wrap appservice invite handler with retry logic - Add comprehensive tests covering retry, sweep, cleanup, and concurrency Authored by: Michael Pretorius <michael@ixo.world>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add retry logic and periodic invite sweep to AutojoinRoomsMixin
The existing autojoin handler was a fire-and-forget joinRoom call with no
error handling. When joinRoom failed (rate limit, network blip, timeout),
the invite was permanently lost because the main sync token had already
advanced. This caused the state bot to silently miss invites during bulk
processing from the onboarding server.
to discover and join any missed invites (60s interval, 90s initial delay)
so failed joins are retried on the next sweep cycle
Authored by: Michael Pretorius michael@ixo.world