Update SeparateJointModelTransform.java #2409
Conversation
Avoid mutating input
| @@ -30,9 +30,12 @@ public void getOffsetTransform(Matrix4f outTransform, Matrix4f inverseModelBindM | |||
|
|
|||
| @Override | |||
| public void applyBindPose(Transform localTransform, Matrix4f inverseModelBindMatrix, Joint parent) { | |||
| localTransform.fromTransformMatrix(inverseModelBindMatrix.invert()); | |||
| Matrix4f safeInverseBind = inverseModelBindMatrix.clone().invert(); // avoid mutating input | |||
There was a problem hiding this comment.
The Matrix4f.invert() method already creates a new object without altering the input object, so there is no need to clone the input matrix before inverting it.
| if (parent != null) { | ||
| localTransform.combineWithParent(parent.getModelTransform().invert()); | ||
| Transform safeParentTransform = parent.getModelTransform().clone().invert(); // same here |
There was a problem hiding this comment.
The Transform.invert() method already creates a new object without altering the input object, so there is no need to clone the parent model Transform before inverting it.
|
Hi @utsavsavani01 , You don't need to clone a Edit: |
Avoid mutating input