WIP - move extractor to dedicated crate#1
Draft
jackbackes wants to merge 1 commit intotask-allocatorfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - optimizing local build speed by moving pyo3 compilation of extractor api to a separate crate.
Why: rebuilding pyo3 adds ~10s to incremental build time on my Mac. This adds significantly to development time. Intended outcome is to be able to incrementally build the indexify binary without having to rebuild pyo3 bindings.
Current status: Extractor and api were isolated and moved to separate crates. I need help unwinding the pyo3 setup so it only recompiles on changes that affect indexify_extractor or its dependencies.