[pull] master from apps4av:master #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added github actions
update to tools ver 34
# Conflicts: # app/build.gradle
Permit reuse of datagram sockets
Partial fix to issue #365 This commit addresses two issues with tile rendering that cause the display to have black regions (missing tiles) where it shouldn't. In Preferences.java, it increases the tile budget by a factor of 2. Specifically, it divides by 0.5, my understanding of the smallest zoom size before we flip to the next zoom level. I used a float there as documentation because maybe someday that magic number changes? ==> But let me know if I should just ditch the goofy float math and int-multiply by 2. That fix wasn't enough, because I'd still see missing tiles because the budget gets clipped by getTilesNumber to the MEM_*_{X,Y} memory limits. The biggest memory limit was based on a whopping 192MB device. My tablet has 4GB and would like more tiles, please. I added a MEM_512 tier with 13×11 tiles. ==> I don't know how the MEM_512_OH value should be calculated. Suggestions invited. In the process of diagnosing these issues, I was getting terribly confused by the draw loop in Tile.java. I refactored it a little to extract some expressions that have intuitive meaning (tileXIndex, tileYIndex, centerTileX, centerTileY) and compute based on those. I think this change is just aesthetic. I tested this manually on an Android emulator by reproducing zoom levels that cause trouble on my tablet.
Fix missing tiles by accounting for zoomed-out tiles and extending memory budget on big RAM devices
Add HeartbeatMessage to BufferProcessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )