Bump actions test runtime to macOS 26#135
Merged
Merged
Conversation
Re-testing on macOS and windows is of low value. Very unlikely to break, where as GH Actions runtimes frequently update and remove certain packages. This also reduces CI complexity. I only need to ensure the runtimes are installed on linux rather than macOS/Windows which may require additional work.
Instead of only running on linux (see last commit), it's easy enough to rather just disable for the runtime environments that do not have it pre-installed. In this case, php is not yet available in macos-26. When it comes to running locally, obviously it's very likely a contributor may not have that runtime available. That's fine.. I'm planning on changing how tests are structured and maybe I'll make things more configurable at that point.
jacobdeichert
commented
Jan 10, 2026
|
|
||
| // GH Actions macos-26 doesn't have php installed by default. Installing it with a | ||
| // 3rd party script is overkill. Testing on linux+windows provides enough confidence. | ||
| #[cfg(not(target_os = "macos"))] |
Owner
Author
There was a problem hiding this comment.
Instead of only running on linux (see last commit), it's easy enough to rather just disable for the runtime environments that do not have it pre-installed. In this case, php is not yet available in macos-26.
When it comes to running locally, obviously it's very likely a contributor may not have that runtime available. That's fine.. I'm planning on changing how tests are structured and maybe I'll make things more configurable so people can easily skip the runtimes they don't have installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the solution
The macos-13 runtime is no longer available. Bumping to 26 for macOS testing.