[v2][feat] Introduce ClickHouse connection configuration #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zzzk1 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6664 +/- ##
==========================================
- Coverage 95.96% 95.61% -0.35%
==========================================
Files 365 367 +2
Lines 20602 21141 +539
==========================================
+ Hits 19770 20214 +444
- Misses 634 711 +77
- Partials 198 216 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Password: "", | ||
| }, | ||
| //nolint: gosec // G402 | ||
| TLS: &tls.Config{InsecureSkipVerify: true}, |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check High
yurishkuro
reviewed
Feb 3, 2025
| // Auth Specify an auth struct in the connection details to specify a username and password. | ||
| Auth Authentication `mapstructure:"auth"` | ||
| // TLS options. A non-nil value enables TLS. | ||
| TLS *tls.Config `mapstructure:"tls"` |
There was a problem hiding this comment.
Won't work, see how other configs are doing TLS
| } | ||
|
|
||
| type Authentication struct { | ||
| Database string `mapstructure:"database"` |
There was a problem hiding this comment.
Why is database part of auth? Can't I auth via TLS and still specify database?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
According to the principle of minimization, provide a connection configuration for subsequent clients connected to
ClickHouse.YAMLconfiguration file for e2e test, including the minimum parameters required to interact withClickHouse.YAMLshould be parsed and applied at runtime.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test