Add a bunch new steam scam domains #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagrosh
requested changes
Jun 16, 2021
|
They're technically second-level domains similarly to .co.uk for example. They're free to be registered like any other TLD, is there a technical reason why you're not supporting this? |
|
The technical reason is that they just wouldn't do anything with how the code currently works; it iterates through all urls in a message and compared the base url to this list, so it would be comparing I guess there's no harm in including them, but it would be confusing for someone reading the source wondering why these links aren't being picked up despite being in this list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch of new domains that are (actively) used to fake Steam trading URLs, this list was compiled by DMD.
Supersedes #101 (sorry bup)