Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove discriminator from log messages & events. #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kaluub
Copy link

@Kaluub Kaluub commented Sep 24, 2023

As all active Discord accounts now use the new username system, it is not needed to use/reference the old discriminators. Currently defaults to 0000.

@Jbziscool
Copy link

There are still lots of active accounts that use the discriminator system so you probably shouldn't remove it.

@Kaluub
Copy link
Author

Kaluub commented Oct 27, 2023

There are still lots of active accounts that use the discriminator system so you probably shouldn't remove it.

Right, when I wrote this I had believed all accounts with discriminators had been automatically assigned their new usernames but I've seen a few accounts without that recently so clearly not. I'm not sure if there's a good solution since most active users will have their new usernames, but since it's not everyone best to be safe with that. Could maybe check if the discriminator is not 0000, but probably too excessive for what it's worth.

@jagrosh
Copy link
Owner

jagrosh commented Oct 27, 2023

Most likely scenario is it excludes the discrim only if it's 0

@Jbziscool
Copy link

Most likely scenario is it excludes the discrim only if it's 0

Correct, if you ask for the discriminator via the discord api it will appear as 0 but if you click on a users profile with the pomelo usernames feature then it will not show the discriminator, only if you query the discord api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants