Avoid caching Connection in ConnectionProvider#12
Open
lukaseder wants to merge 1 commit intojaiew:masterfrom
lukaseder:patch-2
Open
Avoid caching Connection in ConnectionProvider#12lukaseder wants to merge 1 commit intojaiew:masterfrom lukaseder:patch-2
lukaseder wants to merge 1 commit intojaiew:masterfrom
lukaseder:patch-2
Conversation
This practice has been seen a couple of times on the internet, in various sample projects, blog posts, etc. It is generally not a good idea to cache the Connection in a `ConnectionProvider`, as the `ConnectionProvider` should be stateless and threadsafe to be more generally useful, e.g. when injected via DI For example, this user refers to your example and will probably get it wrong: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/play-framework/tXvA76ZQsJs/BoznOslsHwAJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This practice has been seen a couple of times on the internet, in various sample projects, blog posts, etc. It is generally not a good idea to cache the Connection in a
ConnectionProvider, as theConnectionProvidershould be stateless and threadsafe to be more generally useful, e.g. when injected via DIFor example, this user refers to your example and will probably get it wrong:
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/play-framework/tXvA76ZQsJs/BoznOslsHwAJ