Skip to content

Fix tests that make wrong assumptions about character encoding - #349

Merged
KyleAure merged 2 commits into
jakartaee:mainfrom
KyleAure:fix-char-encoding-test-failures
Aug 13, 2026
Merged

KyleAure merged 2 commits into
jakartaee:mainfrom
KyleAure:fix-char-encoding-test-failures

Conversation

@KyleAure

Copy link
Copy Markdown
Member

Fixes #348
Fixes where the TCK makes the wrong assumptions about character encoding.

@KyleAure
KyleAure force-pushed the fix-char-encoding-test-failures branch from 26a7fdb to 95f6c6e Compare August 12, 2026 13:38
@KyleAure KyleAure self-assigned this Aug 12, 2026
@KyleAure KyleAure added bug Something isn't working TCK labels Aug 12, 2026
@KyleAure
KyleAure requested a review from njr-11 August 13, 2026 14:32

@njr-11 njr-11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one typo in a comment that is copied to several places.
That's trivial so I'll add the approval in advance.

Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
@KyleAure
KyleAure merged commit bc9bfd1 into jakartaee:main Aug 13, 2026
4 checks passed
@KyleAure
KyleAure deleted the fix-char-encoding-test-failures branch August 13, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working TCK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TCK] Tests incorrectly assumes that Charset.defaultCharset() is always UTF-8

2 participants