Repository navigation
feat: scan tck for @Test and @Disabled - #468
Conversation
Co-authored-by-AI: IBM Bob (1.126.0+bob2.1.0)
njr-11
left a comment
There was a problem hiding this comment.
Good idea to automate this.
One item to point out from an AI review (Bob) is that it claims mvn test will fail after this.
mvn test and mvn process-classes from the root fail (bug)
The error is Failed to execute goal exec-maven-plugin ... (generate-asciidoc): .../tck/target/classes (Is a directory).
The exec goal is bound to process-classes. When the build stops before package, the reactor resolves the jakarta.json.bind-tck artifact to its target/classes directory instead of a jar.
CollectMetaData.scanJar then opens it with JarInputStream(new FileInputStream(...)), which fails.
CI uses mvn clean install, so it won't catch this. Anyone running mvn test locally will hit it.
Fixes: bind the exec to package or prepare-package, which must run before asciidoctor (also prepare-package), or make the scanner accept a directory.
@njr-11 fixed with commit |
update the TCK Distribution documentation to scan the TCK to determine how many tests there and what challenges exist.
that way we don't need to worry about updating these documents for every release, we can just build the project and trust that the documentation is correct.