Skip to content

feat: scan tck for @Test and @Disabled - #468

Merged
KyleAure merged 4 commits into
jakartaee:mainfrom
KyleAure:tck-assertions
Oct 27, 2026
Merged

KyleAure merged 4 commits into
jakartaee:mainfrom
KyleAure:tck-assertions

Conversation

@KyleAure

Copy link
Copy Markdown
Member

update the TCK Distribution documentation to scan the TCK to determine how many tests there and what challenges exist.
that way we don't need to worry about updating these documents for every release, we can just build the project and trust that the documentation is correct.

@KyleAure KyleAure self-assigned this Sep 21, 2026
@KyleAure KyleAure added enhancement New feature or request TCK labels Sep 21, 2026
@KyleAure KyleAure added this to the 3.1 milestone Oct 26, 2026
@KyleAure
KyleAure requested a review from njr-11 October 26, 2026 19:46

@njr-11 njr-11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to automate this.

One item to point out from an AI review (Bob) is that it claims mvn test will fail after this.

mvn test and mvn process-classes from the root fail (bug)

The error is Failed to execute goal exec-maven-plugin ... (generate-asciidoc): .../tck/target/classes (Is a directory).
The exec goal is bound to process-classes. When the build stops before package, the reactor resolves the jakarta.json.bind-tck artifact to its target/classes directory instead of a jar.
CollectMetaData.scanJar then opens it with JarInputStream(new FileInputStream(...)), which fails.
CI uses mvn clean install, so it won't catch this. Anyone running mvn test locally will hit it.
Fixes: bind the exec to package or prepare-package, which must run before asciidoctor (also prepare-package), or make the scanner accept a directory.

@KyleAure

Copy link
Copy Markdown
Member Author

Good idea to automate this.

One item to point out from an AI review (Bob) is that it claims mvn test will fail after this.

mvn test and mvn process-classes from the root fail (bug)
The error is Failed to execute goal exec-maven-plugin ... (generate-asciidoc): .../tck/target/classes (Is a directory).
The exec goal is bound to process-classes. When the build stops before package, the reactor resolves the jakarta.json.bind-tck artifact to its target/classes directory instead of a jar.
CollectMetaData.scanJar then opens it with JarInputStream(new FileInputStream(...)), which fails.
CI uses mvn clean install, so it won't catch this. Anyone running mvn test locally will hit it.
Fixes: bind the exec to package or prepare-package, which must run before asciidoctor (also prepare-package), or make the scanner accept a directory.

@njr-11 fixed with commit c09bb2c (this PR)

@KyleAure
KyleAure merged commit 470725b into jakartaee:main Oct 27, 2026
4 checks passed
@KyleAure
KyleAure deleted the tck-assertions branch October 27, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request TCK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants