Add offline Samba4X cross-answer configure mode

[jamesyc]

Add offline Samba4X cross-answer configure mode

[gemini-code-assist]

Code Review

This pull request introduces a cross-answer file mechanism for Samba 4.x builds, enabling offline configuration by providing pre-recorded responses to Waf probes. It includes new answer files for NetBSD 4 and 7, updates the build script to manage these files, and adds a comprehensive test suite. Feedback suggests defining SAMBA4X_VERSION in the example environment file and improving the robustness of path calculations for the default answers file by avoiding reliance on an undefined SCRIPT_DIR variable.

[jamesyc]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for offline Samba 4.x builds by utilizing Waf cross-answer files, which eliminates the need for a live SSH connection to a Time Capsule during the configuration phase. The changes include new environment variables in .env.example, the addition of pre-computed answer files for NetBSD 4 (BE/LE) and NetBSD 7, and updates to the _samba4x.sh build script to manage these files. Additionally, a comprehensive Python test suite has been added to verify the build script logic. Feedback provided suggests improving error handling in the script by explicitly checking the return code of the lane selection function to ensure descriptive failures.

[gemini-code-assist]

The return code of samba4x_cross_answer_lane is not checked. If it fails (e.g., due to an unsupported configuration), the script will continue with an empty lane variable, which leads to a less descriptive "Missing Samba 4.x cross-answers file" error later in preflight_samba4x_cross_answers. Explicitly checking the return status ensures the script exits immediately with the specific error message already printed to stderr by the function.

Suggested change

	lane="$(samba4x_cross_answer_lane)"
	if ! lane="$(samba4x_cross_answer_lane)"; then
	exit 1
	fi

[jamesyc]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a cross-answer mechanism for Samba 4.x builds, enabling offline configuration for NetBSD targets without requiring a live device via SSH. The changes include new build scripts, pre-generated answer files for NetBSD 4 and 7, and a suite of unit tests for the build logic. Review feedback suggests refining the Python-based duplicate answer detection in build/_samba4x.sh to provide clearer conflict reports by aggregating unique values per key.