Open
Conversation
CicherMK
approved these changes
Jun 26, 2020
Charly6596
suggested changes
Sep 27, 2020
There was a problem hiding this comment.
Looks good overall, but felt like there is inconsistency with the usage of "tú" and "usted", and found some things that, in my opinion, could be improved
There might be some comments related to country differences (I deleted a few of those tho), since I'm a Spaniard and this looks written by someone from Lat. America, I mean, there is nothing wrong with that, but it's that some expressions I corrected might be right, but they just sound weird to me.
Please let me know what you think about my comments, and I am of course open to any kind of feedback (:
Author
|
Thank you for your comments, @Charly6596 . Already pushed the requested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.