Fix validation on stale values

jaredpalmer · Jan 25, 2024 · bc841a2 · bc841a2
1 parent 0f960aa
commit bc841a2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/.changeset/red-walls-press.md b/.changeset/red-walls-press.md
@@ -0,0 +1,5 @@
+---
+'formik': patch
+---
+
+Fixed validation on stale values
diff --git a/packages/formik/src/Formik.tsx b/packages/formik/src/Formik.tsx
@@ -417,7 +417,12 @@ export function useFormik<Values extends FormikValues = FormikValues>({
         dispatchFn();
       }
     },
-    [props.initialErrors, props.initialStatus, props.initialTouched, props.onReset]
+    [
+      props.initialErrors,
+      props.initialStatus,
+      props.initialTouched,
+      props.onReset,
+    ]
   );
 
   React.useEffect(() => {
@@ -548,7 +553,7 @@ export function useFormik<Values extends FormikValues = FormikValues>({
       const willValidate =
         shouldValidate === undefined ? validateOnBlur : shouldValidate;
       return willValidate
-        ? validateFormWithHighPriority(state.values)
+        ? validateFormWithHighPriority(stateRef.current.values)
         : Promise.resolve();
     }
   );
@@ -559,7 +564,9 @@ export function useFormik<Values extends FormikValues = FormikValues>({
 
   const setValues = useEventCallback(
     (values: React.SetStateAction<Values>, shouldValidate?: boolean) => {
-      const resolvedValues = isFunction(values) ? values(state.values) : values;
+      const resolvedValues = isFunction(values)
+        ? values(stateRef.current.values)
+        : values;
 
       dispatch({ type: 'SET_VALUES', payload: resolvedValues });
       const willValidate =
@@ -592,7 +599,9 @@ export function useFormik<Values extends FormikValues = FormikValues>({
       const willValidate =
         shouldValidate === undefined ? validateOnChange : shouldValidate;
       return willValidate
-        ? validateFormWithHighPriority(setIn(state.values, field, value))
+        ? validateFormWithHighPriority(
+            setIn(stateRef.current.values, field, value)
+          )
         : Promise.resolve();
     }
   );
@@ -677,7 +686,7 @@ export function useFormik<Values extends FormikValues = FormikValues>({
       const willValidate =
         shouldValidate === undefined ? validateOnBlur : shouldValidate;
       return willValidate
-        ? validateFormWithHighPriority(state.values)
+        ? validateFormWithHighPriority(stateRef.current.values)
         : Promise.resolve();
     }
   );