Repository navigation
fix(renderer): eliminate box-drawing gaps - #60
Merged
Merged
Conversation
Owner
Author
|
External review disposition:
No review-driven code changes were required. |
Owner
Author
|
Full Opus review disposition ( Opus found no blocking correctness, security, performance, or regression issue. It independently verified the device-grid invariant, stroke centering, single-composite faint behavior, run isolation, fallback/grapheme path, all 26 glyph mappings and rounded orientations, stable backing-store sizing, and test-harness fidelity. Non-blocking notes consciously accepted for this scoped fix:
No Opus-driven code changes are required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52
Summary
Design notes
I reviewed upstream PRs coder#128 and coder#146, but did not copy either implementation: coder#128 expands into unrelated block/Powerline/visual-infrastructure work, while coder#146 later includes unrelated performance changes. This PR keeps the fix scoped to the reproducible box-drawing seams and uses a single fill path for intersecting straight strokes so translucent/faint cells composite once.
Verification
bun run fmtbun run lint(pre-existing diagnostics only)bun run typecheckbun test(541 passing, 0 failing)bun run build