Merge pull request #62 from jasonlong/fix-longest-streak

Fix longest streak logic
jasonlong · Oct 7, 2016 · aa8a568 · aa8a568
2 parents 9eb9ed6 + e1a7ebb
commit aa8a568
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 42 deletions.
diff --git a/chrome/iso.js b/chrome/iso.js
diff --git a/chrome/manifest.json b/chrome/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "Isometric Contributions",
-  "version": "1.0.12",
+  "version": "1.0.13",
   "description": "Renders an isometric pixel view of GitHub contribution graphs.",
   "content_scripts": [ {
     "css": [ "iso.css" ],

diff --git a/firefox/isometric-contributions.xpi b/firefox/isometric-contributions.xpi
diff --git a/firefox/isometric-contributions/iso.js b/firefox/isometric-contributions/iso.js
diff --git a/firefox/isometric-contributions/manifest.json b/firefox/isometric-contributions/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "Isometric Contributions",
-  "version": "1.0.12",
+  "version": "1.0.13",
   "description": "Renders an isometric pixel view of GitHub contribution graphs.",
   "content_scripts": [ {
     "css": [ "iso.css" ],

diff --git a/safari/isometric-contributions.safariextension/Info.plist b/safari/isometric-contributions.safariextension/Info.plist
@@ -13,9 +13,9 @@
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.0.12</string>
+	<string>1.0.13</string>
 	<key>CFBundleVersion</key>
-	<string>1.0.12</string>
+	<string>1.0.13</string>
 	<key>Chrome</key>
 	<dict>
 		<key>Database Quota</key>

diff --git a/safari/isometric-contributions.safariextension/iso.js b/safari/isometric-contributions.safariextension/iso.js
diff --git a/src/iso.coffee b/src/iso.coffee
@@ -22,7 +22,7 @@ class Iso
       if graphContainer
         observer = new MutationObserver (mutations) =>
           isGraphAdded = mutations.find (mutation) ->
-            [].find.call mutation.addedNodes, (node) -> 
+            [].find.call mutation.addedNodes, (node) ->
               node.className == "js-contribution-graph"
           if isGraphAdded
             this.generateIsometricChart()
@@ -129,7 +129,6 @@ class Iso
     streakCurrent      = 0
     tempStreak         = 0
     tempStreakStart    = null
-    tempStreakEnd      = null
     longestStreakStart = null
     longestStreakEnd   = null
     currentStreakStart = null
@@ -155,19 +154,15 @@ class Iso
       if currentDayCount > 0
         if tempStreak == 0
           tempStreakStart = ($ this).data('date')
-          tempStreakEnd = ($ this).data('date')
 
         tempStreak++
 
-        if tempStreak >= streakLongest
-          tempStreakEnd = ($ this).data('date')
-
-      else
         if tempStreak >= streakLongest
           longestStreakStart = tempStreakStart
-          longestStreakEnd   = tempStreakEnd
+          longestStreakEnd   = ($ this).data('date')
           streakLongest      = tempStreak
 
+      else
         tempStreak         = 0
         tempStreakStart    = null
         tempStreakEnd      = null