Conversation
|
@cyrille-artho |
|
the build is successful now |
cyrille-artho
left a comment
cyrille-artho
left a comment
There was a problem hiding this comment.
Hi Mahmoud,
Thank you for the update. If the other APIs still work, then this looks good. To run the tests, please fix the absolute path on line 17.
/ Cyrille
build.gradle
Outdated
| // jpf-core | ||
| implementation files(jpf.Jar.getFullPath()) | ||
| // JPF-core dependency (adjust path as needed) | ||
| implementation files("/home/finn/jpf-push/jpf-core/build/jpf.jar") |
There was a problem hiding this comment.
Please make sure the paths stay relative, as the absolute paths depends on the user name.
There was a problem hiding this comment.
thanks i modified it to be jpf.Jar.getFullPath() as the previous one
cyrille-artho
left a comment
cyrille-artho
left a comment
There was a problem hiding this comment.
Great, this version passes the tests. Only one comment to remove/revert.
build.gradle
Outdated
|
|
||
| dependencies { | ||
| // jpf-core | ||
| // JPF-core dependency (adjust path as needed) |
There was a problem hiding this comment.
Please remove the comment "(adjust path as needed)", as that's not needed
|
done, thanks! |
2 participants
No description provided.