jax.scipy.linalg.toeplitz: support implicit batching #24842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
force-pushed
the
batched-toeplitz
branch
2 times, most recently
from
315b549
to
5c0a7ff
Compare
jakevdp
force-pushed
the
batched-toeplitz
branch
from
5c0a7ff
to
bf7ee00
Compare
dfm
approved these changes
Nov 11, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
jakevdp
force-pushed
the
batched-toeplitz
branch
from
bf7ee00
to
3f98c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24824.
This implements the batching behavior of
scipy.linalg.toeplitzstarting in scipy v1.17. This is a breaking change, but I opted to avoid the deprecation cycle because I think this behavior is more sensible than the original and I anticipate few users depend on the old behavior.