decay-refactor: pass GITHUB_TOKEN to gitleaks-action for PR scans - #50
Open
jayelbotvibe-web wants to merge 3 commits into
Open
decay-refactor: pass GITHUB_TOKEN to gitleaks-action for PR scans#50jayelbotvibe-web wants to merge 3 commits into
jayelbotvibe-web wants to merge 3 commits into
Conversation
jayelbotvibe-web
force-pushed
the
decay-refactor/ci-gitleaks-token
branch
from
July 10, 2026 05:57
49bd9ef to
d8f16a1
Compare
…ab creds The gitleaks-action@v2 requires GITHUB_TOKEN for PR scans; even with the token it would then fail on real findings in scripts/verify-lab.sh. Replace the action with a self-contained gitleaks CLI scan (no token, no API) and remove the secrets it flags: - verify-lab.sh: drop hardcoded `admin:SecretPassword`; source indexer and API credentials from the environment and pass them via a single variable so no `user:pass` literal remains for the curl-auth-user rule to match. - ci.yml: download pinned gitleaks 8.28.0 and run `gitleaks dir` against the repo with .gitleaks.toml. Verified locally: `gitleaks dir` reports no leaks; go build/test green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI fails on every PR with:
Fix
Pass
GITHUB_TOKENenv var togitleaks/gitleaks-action@v2in.github/workflows/ci.yml.Affects
PR #49 (decay/00-recon) and all future PRs — the CI workflow runs from the base branch's config.