Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to add the application fields to the application form #1385

Closed
wants to merge 3 commits into from

Conversation

housUnus
Copy link

@housUnus housUnus commented Jan 7, 2024

Fixes #
Allow the user to add the application fields to the application form

Description of the Change

Allow the user to add the application fields to the application form

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Add APPLICATION_MODEL to the settings file so it can be specified by the user
Add the custom application fields to the view
@housUnus housUnus changed the title s Allow the user to add the application fields to the application form Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.09%. Comparing base (3e11703) to head (0e85bd4).
Report is 89 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1385      +/-   ##
==========================================
- Coverage   97.56%   97.09%   -0.47%     
==========================================
  Files          32       32              
  Lines        2132     2135       +3     
==========================================
- Hits         2080     2073       -7     
- Misses         52       62      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n2ygk
Copy link
Member

n2ygk commented May 7, 2024

@housUnus please explain what this PR is attempting to do in some more detail. What is your use case?

Also, all the checklist items need to be completed:

  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

There also appear to be some unrelated diffs and a random debugging print()....

@dopry
Copy link
Contributor

dopry commented Oct 2, 2024

@housUnus hey we haven't heard back from you! I'm closing this PR as stale. If you wish to continue please let me know and address n2ygk's concerns and I'll re-open.

@dopry dopry closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants