Prefer f-strings instead of str.format #2164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
force-pushed
the
f-strings
branch
from
c76c46b to
1e897a4
Compare
webknjaz
reviewed
Feb 18, 2025
| @@ -429,9 +429,9 @@ def get_best_match(self, ireq: InstallRequirement) -> InstallRequirement: | |||
|
|
|||
| # Format the best match | |||
| log.debug( | |||
There was a problem hiding this comment.
Logging is supposed to pass params through dedicated arguments, though. Instead of pre-rendering strings before passing them into logging..
There was a problem hiding this comment.
That's exactly what my change does.
Previously a pre-rendered string was being passed (one using .format()). Now dedicated arguments are passed.
Ruff's pyupgrade re-implementation does handle this. This PR and #2163 are groundwork for using ruff instead of flake8+pyupgrade, but can be merged independently. |
WhyNotHugo
force-pushed
the
f-strings
branch
from
1e897a4 to
a6939e2
Compare
|
Not sure about th CI failures. Rebased onto latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No user facing changes.