Skip to content

Commit

Permalink
feat: automatically create issues from todos
Browse files Browse the repository at this point in the history
Create issues via [a nifty github action][1] that expands todos
into issues.
  • Loading branch information
jbergstroem committed Jan 18, 2023
1 parent 50b8bbd commit 97eb7c5
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 5 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/todo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: "TODO to Issue"
on:
push:
branches:
- main

jobs:
todo:
runs-on: ubuntu-22.04
steps:
- uses: actions/[email protected]
- name: "TODO to Issue"
uses: "alstr/[email protected]"
with:
CLOSE_ISSUES: false
4 changes: 2 additions & 2 deletions docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
In order to assist with developing `mariadb-alpine`, the following software is strongly recommended:

- a [containerd][containerd] runtime such as [docker for desktop][docker] or [lima][lima-vm]
- a docker-cli compatible client (@TODO more testing with [nerdctl][], [podman][podman])
- a docker-cli compatible client (TODO more testing with [nerdctl][] and [podman][podman])
- [bash][bash] 4.0 or newer
- [bash_unit][bash_unit] - a bash testing framework
- [shellcheck][shellcheck] to validate shell script
Expand Down Expand Up @@ -43,7 +43,7 @@ There are sanity checks in place to help you from making mistakes:
3. Hit "Run workflow" and wait a few minutes. Should tests or building containers fail, no tags or containers will be published to Github or Docker.
4. Should you run into issues, file a new issue in the repository and assign @jbergstroem.

<!-- @TODO Create a release with gh-cli -->
<!-- TODO Document how to a release with gh-cli -->

[containerd]: https://containerd.io
[docker]: https://docker.com
Expand Down
1 change: 1 addition & 0 deletions sh/build-image.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/bin/bash
# shellcheck shell=bash
set -euo pipefail

IMAGE=${IMAGE:-jbergstroem/mariadb-alpine}
SHORT_SHA=$(git rev-parse --short HEAD)
Expand Down
6 changes: 4 additions & 2 deletions sh/generate-benchmark.sh
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
#!/usr/bin/env bash
# shellcheck shell=bash

set -euo pipefail

# Fetches latest version and compressed size from dockerhub
# Should go into some kind of release engineering at some point
# TODO Benchmark should be run as part of release engineering/automation
# TODO Sort benchmark by container size
# TODO Fetch latest tag instead of digest for containers in benchmark
# TODO Add size factor compared to smallest container in benchmark

declare -A images=(
["mysql"]="library/mysql"
Expand Down
3 changes: 2 additions & 1 deletion sh/my_print_defaults.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
# shellcheck shell=dash
set -euo pipefail

# Stack overflow'ed - should rewrite in awk or even shell for readability
# Stack overflow'ed
# TODO Rewrite parsing config ini in awk or even shell for readability
sed -n \
'/^[ \t]*\[mariadb\]/,/\[/s/^[ \t]*\([^#; \t][^ \t=]*\).*=[ \t]*\(.*\)/--\1=\2/p' \
/etc/my.cnf.d/* | sed 's:#.*$::g'

0 comments on commit 97eb7c5

Please sign in to comment.