Skip to content

Prevent task failing on existing users #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent task failing on existing users #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cafd3c2
Prevent task failing on existing users
koenpunt Nov 23, 2016
3da0aba
fix spec
koenpunt Nov 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/mysql_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def create_database_query(database)


def create_user_query(database, user, password)
"CREATE USER '#{user}'@'%' IDENTIFIED BY '#{password}';"
"CREATE USER IF NOT EXISTS '#{user}'@'%' IDENTIFIED BY '#{password}';"
end


Expand Down
2 changes: 1 addition & 1 deletion spec/models/mysql_adapter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

describe '#create_user_query' do
it 'should return a SQL statement to create user' do
expect(klass.create_user_query('database', 'user', 'password')).to eq "CREATE USER 'user'@'%' IDENTIFIED BY 'password';"
expect(klass.create_user_query('database', 'user', 'password')).to eq "CREATE USER IF NOT EXISTS 'user'@'%' IDENTIFIED BY 'password';"
end
end

Expand Down