#213 Support spring cloud http3 #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengnankkkk
suggested changes
Jul 12, 2025
| break; | ||
| } | ||
| } | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
直接吞掉了所有的异常，应该细化为小的异常，从具体到公共。
反射获取字段未做类型和存在性校验，易导致运行时错误。
publisher.offer 没有判断 publisher 是否为 null。
| @Inject(Publisher.SYSTEM) | ||
| private Publisher<AgentEvent> publisher; | ||
|
|
||
| public SpringNettyWebServerDefinition() { |
There was a problem hiding this comment.
publisher 注入未做空值校验，可能导致 NPE。
只拦截了 NettyWebServer 的 start 方法，未考虑其他生命周期方法，可能遗漏部分启动场景。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add SpringNettyWebServerDefinition
add SpringCloudHttp3Interceptor
add Maven Dependency reactor-netty-http