Skip to content

fix(install): disable global virtual store for Metro apps - #1297

Merged
jdx merged 2 commits into
mainfrom
codex/fix-metro-gvs-autodisable
Aug 15, 2026
Merged

fix(install): disable global virtual store for Metro apps#1297
jdx merged 2 commits into
mainfrom
codex/fix-metro-gvs-autodisable

Conversation

@jdx

@jdx jdx commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • add expo, react-native, and metro to the default disableGlobalVirtualStoreForPackages list
  • document Metro's requirement that external symlink targets appear in watchFolders
  • cover all three new direct-dependency triggers in the GVS auto-disable BATS suite

Why

Metro's file map cannot resolve packages whose realpaths live in aube's global virtual store outside the project root. This affects standalone Metro projects as well as typical Expo and React Native apps. Per-project materialization keeps those realpaths inside the project and restores resolution.

Explicit --enable-global-virtual-store continues to override the compatibility heuristic by design.

Closes the compatibility gap reported in #1294.

Validation

  • cargo fmt --check
  • cargo clippy --all-targets -- -D warnings
  • mise run test:bats test/nextjs_gvs_autodisable.bats

AI-assisted — Tool: Codex; model: unavailable; version: unavailable.


Note

Low Risk
Default-only config change with existing heuristic; affects install layout/disk for Metro/Expo/RN projects but does not alter override flags or core linker logic.

Overview
Extends the default disableGlobalVirtualStoreForPackages list with expo, react-native, and metro, so aube install automatically switches to per-project virtual-store materialization when any of those names appear in an importer’s deps (same warning/heuristic as Next/Nuxt/Parcel).

Docs in settings.toml and docs/settings/index.md now describe Metro’s symlink/watchFolders constraint and note that Expo/React Native usually depend on the framework package rather than metro directly.

A new BATS case loops over all three packages and asserts the disable warning plus non-symlinked node_modules/.aube/ layout.

Reviewed by Cursor Bugbot for commit f8e078d. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Bug Fixes

    • Improved compatibility for Expo, React Native, and Metro projects by automatically disabling the global virtual store when needed.
    • Prevented Metro-related filesystem-root failures and ensured project dependencies are materialized correctly.
  • Documentation

    • Expanded settings documentation with the updated default package list and guidance for Metro, Expo, and React Native projects.
  • Tests

    • Added coverage confirming the compatibility behavior for Metro-based frameworks.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a18b5a44-4dc4-4b30-9f06-14030cfde8cd

📥 Commits

Reviewing files that changed from the base of the PR and between e6c9540 and f8e078d.

📒 Files selected for processing (3)
  • crates/aube-settings/settings.toml
  • docs/settings/index.md
  • test/nextjs_gvs_autodisable.bats

📝 Walkthrough

Walkthrough

The default global virtual store exclusions now include expo, react-native, and metro. Documentation explains Metro filesystem constraints. Tests verify warnings and per-project dependency materialization for these packages.

Changes

Global virtual store compatibility

Layer / File(s) Summary
Package exclusions and rationale
crates/aube-settings/settings.toml, docs/settings/index.md
The default exclusion list now includes expo, react-native, and metro. The documentation describes Metro project-root and watch-folder constraints.
Autodisable test coverage
test/nextjs_gvs_autodisable.bats
Tests verify the disable warning and directory materialization for expo, react-native, and metro dependencies.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f8e07

The change extends the existing compatibility default for Metro, Expo, and React Native projects and documents the related configuration requirement; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

  • jdx/aube#1106: Extends the same global virtual store setting and autodisable tests.

Poem

A rabbit hops through Metro’s gate,
With Expo bundles packed in straight.
React Native joins the cheer,
Symlink troubles disappear.
The virtual store knows the way.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: disabling the global virtual store for Metro applications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR expands the default global-virtual-store compatibility heuristic to Metro-based projects.

  • Adds expo, react-native, and metro to the default trigger list.
  • Documents Metro’s symlink-target and watch-folder constraint.
  • Adds direct-dependency regression coverage for all three package names.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
crates/aube-settings/settings.toml Expands the generated list default and documents why Metro ecosystem projects require per-project materialization.
docs/settings/index.md Keeps the generated settings reference aligned with the updated registry default and explanatory text.
test/nextjs_gvs_autodisable.bats Exercises the existing auto-disable path independently for direct dependencies on Expo, React Native, and Metro.

Reviews (2): Last reviewed commit: "test(install): satisfy shellcheck in GVS..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

Instruction counts

benchmark trend instructions Δ wall (min) Δ
graph ▁▂██▁▇▁▂▂█▃▁▂▁▁█▂▁▂▁ 17,573,471 → 17,562,842 -0.06% 4.38 → 4.56ms +3.99%
install ▁▂▁▁▁▁▁▇▇▆▇▆▇▇▆▇▆▇▆█ 108,615,568 → 108,644,568 +0.03% 24.83 → 24.87ms +0.15%
startup ▂▂▃▃▃▁▁▅▅▅▂▂▆▇▇▇▁▇▇█ 7,482,969 → 7,483,787 +0.01% 3.31 → 3.38ms +2.21%
tree █████████▇█▇████▇▁██ 17,747,501 → 17,749,426 +0.01% 4.57 → 4.32ms -5.54%

No instruction-count regression above 1%.

Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.

Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.

f8e078d7fea8 vs e21b4b4ee032 · measured on this runner, not pushed to the history.

@jdx
jdx merged commit 84cc7f8 into main Aug 15, 2026
21 checks passed
@jdx
jdx deleted the codex/fix-metro-gvs-autodisable branch August 15, 2026 01:13
@cursor cursor Bot mentioned this pull request Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant